Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

task: expose table filter for backup full and restore full (#313) #401

Merged
merged 5 commits into from
Jul 21, 2020

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Jul 3, 2020

What problem does this PR solve?

Cherry-pick #313 to release-3.1

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Side effects

Related changes

Release Note

  • Supports advanced table filtering.

…ap#313)

* task: expose table filter for `backup full` and `restore full`

* task: move the invalid backup check out

* task: removed a useless `if err != nil` check

Co-authored-by: pingcap-github-bot <[email protected]>
@kennytm
Copy link
Collaborator Author

kennytm commented Jul 8, 2020

$ go mod why github.com/pingcap/pd/v4/client
# github.com/pingcap/pd/v4/client
github.com/pingcap/br/cmd
github.com/pingcap/tidb/ddl
github.com/pingcap/tidb-tools/tidb-binlog/pump_client
github.com/pingcap/pd/v4/client

🤔

@kennytm
Copy link
Collaborator Author

kennytm commented Jul 8, 2020

blocked by pingcap/tidb-tools#372

@kennytm kennytm force-pushed the cherry-pick-313-to-3.1 branch from 3236b5d to a5022bb Compare July 9, 2020 09:31
@kennytm kennytm removed the status/WIP label Jul 9, 2020
@kennytm kennytm requested review from 3pointer and YuJuncen July 9, 2020 09:41
Copy link
Collaborator

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@YuJuncen,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jul 9, 2020
@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Jul 21, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Jul 21, 2020
@3pointer 3pointer merged commit 6195461 into pingcap:release-3.1 Jul 21, 2020
@kennytm kennytm deleted the cherry-pick-313-to-3.1 branch July 21, 2020 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants